Skip to content

Added examples for SectionList#30390

Closed
kshitij86 wants to merge 5 commits into
facebook:masterfrom
MLH-Fellowship:add-examples-sectionlist
Closed

Added examples for SectionList#30390
kshitij86 wants to merge 5 commits into
facebook:masterfrom
MLH-Fellowship:add-examples-sectionlist

Conversation

@kshitij86

Copy link
Copy Markdown
Contributor

Summary

Added examples for the following missing props in SectionList

  • Prop: initialNumToRender
  • Prop: ListEmptyComponent
  • Prop: onEndReached

Motivation - Missing examples for these props in the RNTester app

Changelog

[General] [Added] - Added examples for the missing props in SectionList

Test Plan

empty
end

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2020
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Nov 14, 2020
@analysis-bot

analysis-bot commented Nov 14, 2020

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4700075

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,525,350 -6
android hermes armeabi-v7a 7,110,599 -1
android hermes x86 7,965,808 -12
android hermes x86_64 7,877,110 -6
android jsc arm64-v8a 8,989,690 +0
android jsc armeabi-v7a 8,558,047 +0
android jsc x86 8,991,657 +0
android jsc x86_64 9,543,213 +0

Base commit: 480dabd

@kshitij86 kshitij86 force-pushed the add-examples-sectionlist branch from 4f9642a to 13097fa Compare November 14, 2020 06:59
@kshitij86 kshitij86 changed the title Added examples to for SectionList Added examples for SectionList Nov 15, 2020
@kshitij86

Copy link
Copy Markdown
Contributor Author

@rickhanlonii Could you please review these changes?

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @kshitij86 in 328590d.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 2, 2020
@rickhanlonii rickhanlonii deleted the add-examples-sectionlist branch December 3, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants